search

oleg-shilo / Favorites.vscode

VSCode extension for managing Favorites
MIT License
23 stars 6 forks source link

Suggestion: If 'Data Location' setting is blank, parse it as <default> instead of "favorites.dataLocation": "" #34

Closed carloscadux closed 2 years ago

carloscadux commented 2 years ago

Hi,

Just a suggestion to avoid an error due to 'Data Location' left blank.

I removed a custom path a had set in the extension 'Data Location' settings, leaving a blank field.

After that the error shown in the screenshot below started appearing.

Later I noticed directly in VSCode settings.json that the extension added the entry "favorites.dataLocation": "",

I deleted the entry and notice that the 'Data Location' setting was restored to

Just then I realized that through the settings UI I needed to retype to reset the path.

The suggestion I'm making is aimed to avoid the error because of the blank field, by parsing it as .

Otherwise, I'd suggest leaving a tip under ''Data Location' setting UI, informing the user to type in order to restore the default path.

Thank you! Carlos

image

image

GitMensch commented 2 years ago

Done, so maybe close?

oleg-shilo commented 2 years ago

I usually wait a few days in case of an immediate defect report. Seems OK now