oleg-shilo / Favorites.vscode

VSCode extension for managing Favorites
MIT License
23 stars 6 forks source link

Support Icon Theme for Tree and mouse click behavior #5

Open FreeHarry opened 6 years ago

FreeHarry commented 6 years ago
  1. Support icon themes for files and folders within the tree. It can help to better distinguish the single elements.

  2. When you double click on a file in 'normal' folder tree it is opened in a new tab right now (and not only in preview mode). When you press ALT-key at clicking on a file it is opened in a new group.

Would be great if you could implement that! And btw: Thanks for your great extension!

oleg-shilo commented 6 years ago

Thank you. I am glad you like it :)

Unfortunately implementing both enhancements is problematic:

  1. Accessing stock icon themes is not implemented. It is still an open VSCode issue: https://github.com/Microsoft/vscode/issues/31466

  2. This one is also impossible. VSCode/Node.js does not allow accessing the keyboard state. You can config keyboard shortcuts to be triggered when certain modifiers key (e.g. Alt) is pressed so the extension command can be triggered, but you cannot detect the keyboard state when an internal VSCode UI element triggered an event (TreeViewItemClicked or TreeViewItemExpanded).

That's why I had to do the trick with the "command item":

image

FreeHarry commented 6 years ago

Ok, that is comprehensible. We will be waiting of better support out of the vscode api.

GitMensch commented 2 years ago

Actually for 1 - the referenced issue was closed because there's an option to use codicons in the tree view since 2020, so this is likely solvable now, isn't it? The this may be moved out to a separate issue that can be worked on (and afterwards closed).

For 2: Because of vscode api limitation that seems not doable (currently) - maybe replace the won't fix by "vscode limitation" or similar?

oleg-shilo commented 2 years ago

Agree. Needs to be reviewed and updated. Will do

oleg-shilo commented 2 years ago

Done. Both of your suggestions. Thank you