Closed vsopko closed 4 months ago
Agreed with "...It's hard to distinguish between the node coloured...". I think the proper way is to remove border from nodes and define 3 colors for each state (like with flat buttons):
Also please look that list border was removed (available only on bottom side for expander visual splitting) and expander content slightly padded from top.
In general, it seems to me that everything is clear and the decision is at your discretion
Done.
I decided to keep the existing selection visual effect (with minor layout adjustments) but otherwise, all the suggestions we discussed ended up in the final solution.
Thank you for sharing ContextMenu styling. It saved me the time of repeating the IDE styling.
I will be closing this PR as almost all its content is now in the codebase anyway.
Thank you for helping out.
I am not sure I am sold on the new UX the PR delivers.
Good UX and DevX:
Ironically I also played with it yesterday.
This is the progress:
Make (remove) the border of hovered and active nodes rectangles same color as background (like in Git Changes window). It will clean up UI I decided to keep the existing UX for the reasons above.
Make bookmarks background under the full node, not only behind text. It will fasten visual recognition. done But I will need to update all dark theme node-icons to ensure they are not blending too much into the background as they do now.
Make bookmarks popup on full node right-click, not ony on text. It's disorienting now. done
This is what I have so far (bookmarks-styling branch):