Explorer implementation doesn't work

oleg-shilo / codemap.vscode

Code map (syntax tree) of the active document

MIT License

84 stars 28 forks source link

Explorer implementation doesn't work #28

Closed AlencarGabriel closed 4 years ago

AlencarGabriel commented 4 years ago

Hi, I was testing the new configuration to change the location of the View CodeMap (#27), when I realized that it was not working.

Configuration

``` json "codemap.prw": "C:\\Users\\g_santana\\AppData\\Roaming\\Code\\User\\mapper_prw.js", "codemap.prx": "C:\\Users\\g_santana\\AppData\\Roaming\\Code\\User\\mapper_prw.js", "codemap.textModeExpanded": false, "codemap.textMode": false, "codemap.location": "codemap", ```

oleg-shilo commented 4 years ago

Don't forget to reload VSCode. I just have tested it:

Seems to work...

AlencarGabriel commented 4 years ago

Yes, I recharged VsCode as a guarantee.

As you can see in the prints, the view appears, but does not show the code structure.

oleg-shilo commented 4 years ago

You are right. Sorry I missed this point. The code change was contributed by @greatpate I will ask him to have a look. Hopefully it's just a tiny configuration issue.

AlencarGabriel commented 4 years ago

Thankful!

This option is really useful, when I saw the release notes I already wanted to configure.

Waiting for correction.

greatpate commented 4 years ago

Hi Oleg, Sorry I haven't been with my computer for a few days. I think the issue is in the package.json where we have the commands During my testing of the feature I must have had the explorer id set to codemap at one point and it not need to refresh. I still don't have access to my computer unfortunately but hopefully my suggestion helps

oleg-shilo commented 4 years ago

Hey Daniel, thank you for stepping in. Ironically my bandwidth is not so great either. Just out of the hospital. Though I managed to do a quick test.

The changes you suggested are logical but it looks like it's not enough. Even the code below does not help:


            "view/title": [
                {
                    "command": "codemap.refresh",
                    "when": "view == explorer",
                    "group": "navigation@2"
                }
            ],
            "view/item/context": [
                {
                    "command": "codemap.navigate_to_selected",
                    "when": "view == explorer && viewItem == file"

oleg-shilo commented 4 years ago

Done. Fixed in Release v1.10.4

AlencarGabriel commented 4 years ago

Very good! Now in Explorer view everything is working correctly.

Thanks for listening!