search

oleg-shilo / wixsharp

Framework for building a complete MSI or WiX source code by using script files written with C# syntax.
MIT License
1.12k stars 175 forks source link

Invoking event after generating script file fix #1594

Closed tereshchuk055 closed 4 months ago

tereshchuk055 commented 4 months ago

It seems that event should be invoked after script file has been generated

oleg-shilo commented 4 months ago

Слава Українi!

Владiслав, the event is intended to be invoked before the builder script is saved for further execution. The idea is that the user can modify the build script (if required) from the event handler, then it is saved and then executed.

Is this design causing the problems in your case?

tereshchuk055 commented 4 months ago

Героям Слава!

Sorry, it was my misconception. Previously, I used the WixSourceSaved event in ManagedProject and didn't notice that NsisBootstrapper uses NsiSourceGenerated but does not have the SourceSaved event. I expected to manually edit the .nsi script file and didn't notice that I can modify the script itself before it is written to the file.

Appreciate your help, the issue is solved!