olegantonyan / googletest

Automatically exported from code.google.com/p/googletest. Added qmake build
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

MSVC6 port #150

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently I'm porting googletest to MSVC6.

I've created patch (for Rev216 = Ver1.3.0).
Currently, gtest.lib build fine and 306 gtest_unittest.cc passed.

As you may know VC6 provide very poor support for C++ standards. 
So my changes may mess up code base.

But some of my projects are written in MSVC6 without any tests, and to 
migrate newer version safely, I think its better to write test. And gtest 
is my favorite.

Could someone review? or is it OK to upload my patch to Rietveld?

Original issue reported on code.google.com by kyossi...@gmail.com on 26 May 2009 at 4:15

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the contribution!  Much appreciated.  Have you signed the CLA yet?  
You
can find the instructions on
http://code.google.com/p/googletest/wiki/GoogleTestDevGuide.  Also, could you 
make
your patch against the trunk head?

Original comment by zhanyong...@gmail.com on 2 Jun 2009 at 7:49

GoogleCodeExporter commented 9 years ago
Hi Wan, Thanks for response.

I have signed individual CLA electronicaly a week ago, but no confirmation 
e-mail.
Is this normal?

I'll try to make patch against trunk. 

Thanks!

Original comment by kyossi...@gmail.com on 3 Jun 2009 at 2:26

GoogleCodeExporter commented 9 years ago

Original comment by zhanyong...@gmail.com on 5 Jun 2009 at 12:24

GoogleCodeExporter commented 9 years ago
I've created an unsupported-vc6-port branch
(http://code.google.com/p/googletest/source/browse/#svn/branches/unsupported-vc6
-port) and
committed the patch into it.

Original comment by zhanyong...@gmail.com on 5 Jun 2009 at 6:00