search

olegantonyan / mpz

Music player for big local collections
https://mpz-player.org/
Other
85 stars 2 forks source link

Right click opens new instance #115

Closed vexillia closed 3 years ago

vexillia commented 3 years ago

In v1.07 right clicking on an mp3 file opens a second instance on mpz. I expected it to re-use the existing instance.

xUbuntu 20.02 / xfce / Thunar file manager.

olegantonyan commented 3 years ago

Could you please explain why you need to right click and open mp3 from filemanager? The player has directory tree, you can have many different folders right in the main window. Is this UX bad so you have to fall back into filemanager, or something else?

vexillia commented 3 years ago

The UX is fine it's just a habit I have acquired over the years using other audio players. Think about it this way: if I've just ripped a CD and I am filing the songs in a file manager it is a lot less clicks to open mpz straight from the file manager.

olegantonyan commented 3 years ago

Ok, will think about it. Reusing one instance is a bit more involved though. Looks like another thing that should be configurable

vexillia commented 3 years ago

Just found more consequences of multiple instances:

[1] Use of the play MPRIS command launches a new instance rather than playing any paused track. [2] The playlists on the separate instances are different. So if you want to keep the new track in the playlist you have to re-enter it.

olegantonyan commented 3 years ago

Version 1.0.9 allows to keep single instance. To enable this: echo "single_instance: true" >> ~/.config/mpz/global.yml. Files passed as cli arguments will be sent to running instance as a new playlist

[1] Use of the play MPRIS command launches a new instance rather than playing any paused track.

Can you please describe this in more details? This sounds like completely unrelated issue

vexillia commented 3 years ago

Just checked with v1.08 and the MPRIS issue has gone! Closing with thanks.

vexillia commented 3 years ago

Just checked with v1.08 and the MPRIS issue has gone! Closing this part issue with thanks.

vexillia commented 3 years ago

Sorry right click issue remains so re-opened. Will now download an check v1.09.

vexillia commented 3 years ago

Thanks for v1.09. Single instance on right click in file manager works just fine.