olegbl / d2rmm

Mod Manager for Diablo II: Resurrected
https://www.nexusmods.com/diablo2resurrected/mods/169
MIT License
54 stars 9 forks source link

Subsection feature #14

Closed alex-c-i closed 1 month ago

alex-c-i commented 5 months ago

Hello,

I implemented a pseudo loot filter that allows removing all item bases individually in D2R and organized them by TC as this is how the game does it internally but people and I quickly realised its not that good of a structure. I will reimplement it as:

Is this something you will consider adding support for in D2RMM ?

PS: as a bonus an enable / disable all toggle for each section / subsection would also be very helpfull.

Thanks, Alex.

olegbl commented 5 months ago

Yup, that seems reasonable. In fact, I think UX options for mod settings need to be expanded quite a bit as more complex mods are being developed. I just don't have any time to do so right now.

alex-c-i commented 5 months ago

D2RMM itself is a bit too complex for me at the moment so no promises for now as to whether I can figure out how to implement these features myself but I will try to have a deeper look into it over the weekend.

Caedendi commented 5 months ago

I second these 2 requests, thanks for considering them.


EDIT: my view on the master toggle for a (sub)section would be to have a switch that would either follow whatever is toggled below (on) or disable whatever is toggled below (off). I have already implemented this in practice in my extended filter, so it could be as simple as a clone of the current checkbox but one that also toggles a visual change to the D2RMM settings menu.

A combination of @alex-c-i's and my suggestion could be a three-way toggle: - off: disable (sub)section - mid: enable whatever is toggled in the (sub)section - on: enable all

But one could argue this would be a complex implementation for what would arguably be confusing UI/UX. EDIT2: looking back this was a bad idea.