search

olegbl / d2rmm

Mod Manager for Diablo II: Resurrected
https://www.nexusmods.com/diablo2resurrected/mods/169
MIT License
54 stars 9 forks source link

Values in the last column of TSVs have a spurious carriage return #4

Closed shlemas closed 1 year ago

shlemas commented 1 year ago

This line: https://github.com/olegbl/d2rmm/blob/master/src/main/preload.js#L193

It splits on \n, but the lines evidently end with \r\n. This leaves a spurious \r character on every value in the last column in every file. This also means keying into the last column doesn't work. E.g. row["*eol"] doesn't work, you have to do row["*eol\r"]. Splitting on \r\n should fix it.

I was going to make/test this change and submit a pull request, but setting up a node.js dev environment on Windows quickly turned into a broken mess that didn't feel worth the time figuring out. So I'm hoping it's something you can throw in.

Thanks! D2RMM is very cool.

shlemas commented 1 year ago

Ugh sorry, this is already reported multiple times.