search

oleghnidets / TweeTextField

Lightweight set of text fields with nice animation and functionality 🚀
MIT License
491 stars 59 forks source link

Fix placeholder animation glitch #19

Closed loicgriffie closed 6 years ago

loicgriffie commented 6 years ago

Implementation Details :construction:

When using embedded view, setText will happen on viewWillAppear on parent view controller. Having a placeholder animation will have placeholder animation not being completed once view appeared on screen and will make the overall appearance like having glitch.

I propose to lock placeholder animation only in case textfield is editing otherwise no animation is used to move the placeholder.

loicgriffie commented 6 years ago

@oleghnidets any chance you can review the MR ?

oleghnidets commented 6 years ago

Hi @loicgriffie I will review within few days. Thank you for your help

oleghnidets commented 6 years ago

@loicgriffie Could you, please, check the latest release? I made a lot of changes since that time.