search

olegkoval / magento-contacts_form_captcha

Magento module "Contacts Form Captcha"
19 stars 14 forks source link

Increase private method to protected, fix some Zend style guideline issues #4

Closed robbieaverill closed 8 years ago

robbieaverill commented 8 years ago

Hi Oleg,

I've increased the visibility of _isCaptchaValid here to protected so that controllers extending yours can still use it.

I've also applied some Zend style guidelines to some of the code for consistency. The only functional change I added is that isCaptchaValid() becomes _isCaptchaValid(), however it is not a breaking change because the method was private. Something to be aware of in case it has been overloaded in extended classes.

Let me know if you have any questions.

Cheers, Robbie