search

olegkrivtsov / using-zend-framework-3-book

A free and reader-friendly book on Zend Framework 3
https://olegkrivtsov.github.io/using-zend-framework-3-book/html
Other
162 stars 63 forks source link

Improve translation #70

Closed glengemann closed 6 years ago

olegkrivtsov commented 6 years ago

Hi @omerta thank you, I reviewed this PR and I have one request regarding this fragment:

// Define the alias in the beginning of the file.
use Zend\Mvc\Application;   use Zend\Mvc\Application as App;

 // Later in your code, use the short class name.   // Later in your code, use the short class name.
$application = new Application();   $application = new App();

I see you changed the logic here (not only translated). I intentionally didn't introduce an alias here to keeps things simple. Could you please leave this fragment as is?

glengemann commented 6 years ago

Sure. Sorry for the intrusion.

@olegkrivtsov, thanks for you understanding.

olegkrivtsov commented 6 years ago

Merged, thanks @omerta