search

olegkutkov / open-phd-guiding

Automatically exported from code.google.com/p/open-phd-guiding
0 stars 0 forks source link

Crash when “dither” or “guide” is initiated from SGP #398

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I encountered a reproducible crash condition with the (currently) latest PHD 
2.4.1g and SGP 2.4 beta 10.

Steps to reproduce:
1. Start PHD, connect equipment (I used Simulator and On-Camera), start guiding
2. Start SGP, connect equipment (I used my real gear)
3. Create a sequence with at least two frames, enable PHD guiding, dithering 
and sequence recovery.
4. Start the sequence, after the first image has completed the dithering 
request from SGP causes PHD to crash.

SGP now enters sequence recovery mode.

5. Start PHD again, connect camera & mount, and start guiding again.
6. Once SGP continues the sequence, it attempts to restart guiding, which 
crashes PHD again.

Please find attached excerpts from the debug log just prior to the crash.

Original issue reported on code.google.com by jari.sau...@gmail.com on 12 Feb 2015 at 7:04

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Jari,

I cannot reproduce the crash on my system. Could you please attach a full debug 
log (not just the excerpt)?

Thanks,
Andy

Original comment by andy.gal...@gmail.com on 12 Feb 2015 at 10:41

GoogleCodeExporter commented 9 years ago 
Jari,

Never mind about the full debug log. I talked to Ken from SGP and we figured 
out the problem.

1. We assume you have "," as your decimal separator. That causes SGP to send a 
mal-formed request to PHD2.  (SGP bug)
2. PHD2 fails to handle the mal-formed request and crashes (PHD2 bug).

Ken says he has now fixed the SGP bug, so you will no longer get the phd2 crash 
after you upgrade to the version of SGP that has Ken's fix (Beta 11).

I have also fixed the PHD2 bug so pHD2 will no longer crash, but it will reject 
the bad messages being sent from SGP.

Andy

Original comment by andy.gal...@gmail.com on 13 Feb 2015 at 5:29

GoogleCodeExporter commented 9 years ago

Original comment by andy.gal...@gmail.com on 13 Feb 2015 at 5:29

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1512.

Original comment by andy.gal...@gmail.com on 13 Feb 2015 at 5:33