search

olegtarasov / VSIconizer

Visual Studio Iconizer extension.
https://marketplace.visualstudio.com/items?itemName=OlegTarasov.VisualStudioIconizerforVisualStudio15
MIT License
18 stars 5 forks source link

Feature request: Option to show the icon *and* the title in tabs #3

Open daiplusplus opened 4 years ago

daiplusplus commented 4 years ago

With apologies for the feature-creep, but I'd love it if this extension fully brought-back the old VS2002-VS2010 style where icons and titles were visible in tool-tabs - this is because often the icons that VS uses are too visually similar so it helps to be able to see the shape of the words (The "Bouma shape") to quickly identify tool windows.

Nostalgia in Visual Studio.NET 2002:

image

...and VS 2005:

image

olegtarasov commented 3 years ago

Hi @Jehoel! This feature is now complete thanks to @aliceif. You can download v 1.23 from the gallery.

daiplusplus commented 3 years ago

@olegtarasov I installed the extension now - looks good with one minor annoyance: there doesn't seem to be a way to control the spacing between the icon and the text, but changing the horizontal margin setting does seem to have an effect, but I'm not sure why/how it works.

I'll see if I can submit a PR - or at least figure out what's going on...

olegtarasov commented 3 years ago

Hi @Jehoel! Spacing between icon and text is computed as horizontal margin divided by 2. If you'd like for it to be configurable as well, feel free to make a new PR. But please be sure to make new spacing setting visible only when checkbox is checked. Thank you!

daiplusplus commented 3 years ago

@olegtarasov sure - my PR is almost ready. My approach is to apply the margin to the <Grid> instead of to the <Image> and then specify margin to the <Image> for image-to-text spacing (bottom margin for vertical, right margin for horizontal). Visually it's the same. Is that okay?

I've taken the liberty of improving some code-quality issues - is it okay to include that in the same PR?

olegtarasov commented 3 years ago

@Jehoel, yes this makes sense. And sure, I will appreciate code quality improvements :)

daiplusplus commented 3 years ago

@olegtarasov Have fun: https://github.com/olegtarasov/VSIconizer/pull/8