search

olehmberg / winter

WInte.r is a Java framework for end-to-end data integration. The WInte.r framework implements well-known methods for data pre-processing, schema matching, identity resolution, data fusion, and result evaluation.
Apache License 2.0
109 stars 32 forks source link

GeneralisedJaccard Constructor to match convention. #36

Closed daidoji closed 5 years ago

daidoji commented 5 years ago

Adjusted GeneralisedJaccard Constructor to take a threshold and Similarity Measure at constructor time so as not to make a Similarity Measure that will fail at runtime with a nullpointer exception when it looks for a threshold or similarity that might not exist if you don't set it explicitly.

Added test and adjusted subclass to account for change in constructor.

olehmberg commented 5 years ago

Hi @daidoji , thank you for contributing this change!