search

olehs / PZEM004T

Arduino communication library for Peacefair PZEM-004T Energy monitor
MIT License
225 stars 114 forks source link

Added wiring diagrams, datasheet and comments on code #18

Open pcgayan opened 7 years ago

pcgayan commented 7 years ago

Added Datasheet of PZEM004T Added Wiring diagram Added comments for RX, TX on Arduino

mandulaj commented 2 years ago

Hey, I am maintaining the PZEM004T-v30 library https://github.com/mandulaj/PZEM-004T-v30 which is very similar in terms of the hardware. I have many users being confused about the wiring. Would you mind adding your drawing also there so that the confusion can be resolved for once. Thank you

pcgayan commented 2 years ago

Hi,

I have pushed the diagram many years back on my branch and a pr.

Which I got 0 reply to merge to master. That would help wiring diagram for resolve Confusion

Thnks

On Sat, Jan 15, 2022, 01:01 Jakub Mandula @.***> wrote:

Hey, I am maintaining the PZEM004T-v30 library https://github.com/mandulaj/PZEM-004T-v30 which is very similar in terms of the hardware. I have many users being confused about the wiring. Would you mind adding your drawing also there so that the confusion can be resolved for once. Thank you

— Reply to this email directly, view it on GitHub https://github.com/olehs/PZEM004T/pull/18#issuecomment-1013550711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMDKQ4VHQVTGGMZ2ODNN4TUWC2MLANCNFSM4DM342KA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

mandulaj commented 2 years ago

Yeah so would you like to add it to my library instead. I am not going to ignore the pull request 😉

olehs commented 2 years ago

Hi. I'm sorry, I completely forgot about this request.

The reason I didn't accept it at the first place was that it not only adds datasheets as stated in the title, but also modifies example's workflow. These changes should be split to different PR's.

Also I doubt I can accept example's changes without further discussion. With these changes, when AC power is off, there will be last positive reading in the freezed log. This can be confusing.

vortigont commented 2 years ago

Hello @olehs, @mandulaj, all lib devs in one place, huh :) Just wanted you to suggest adding a links to docs and pages in different repo's. Would be much easier for users to search for connection diagrams and proper libs. I.e. Oleh has a very nice WiKi pages describing hardware setup with esp8266. I've made a 3-phase setup diagram not so long ago. Also I found a really good repo with PZEM's reverse-engineered schematics. This is all scattered pieces of information, would be nice to have references one to another. Cheers!

mandulaj commented 2 years ago

When I originally wrote my version of the library this was my goal. Just haven't had the time to sit down and collect all the pieces. If you have time and motivation then you are welcome to take the initiative 😇

vortigont commented 2 years ago

Time is the most precious resource for all of us :) OK, I may come up with a list of "useful links" next time.