oleiade / reflections

High level abstractions over the Go reflect library
https://pkg.go.dev/github.com/oleiade/reflections
MIT License
524 stars 51 forks source link

Go modules require a major-version suffix on the name #15

Closed novas0x2a closed 2 years ago

novas0x2a commented 3 years ago

This adds the major-version suffix to the module name. This isn't actually required for v1, but when you bump to v2 it will break callers of the module without it (see https://golang.org/ref/mod#major-version-suffixes)

oleiade commented 2 years ago

Literally years later, sorry for that… As you pointed it out: “Starting with major version 2" and “Major version suffixes are not allowed at major versions v0 or v1.” Unless I end up having some grand inspiration at some point (which after ten years, I guess should have happened by now) I believe there won't be a v2 anyway.

Thus, I won't be merging this. Thank you so much for your contribution, though, I really appreciate it 🙇🏻