search

oleiade / reflections

High level abstractions over the Go reflect library
https://pkg.go.dev/github.com/oleiade/reflections
MIT License
524 stars 51 forks source link

Update reflections.go #19

Closed vihoyau closed 2 months ago

vihoyau commented 2 years ago

when i use go version 1.19, it will throw the panic: panic: reflect.Value.Interface: cannot return value obtained from unexported field or method i change the " reflect.Interface{}" to "reflect", its ok.

oleiade commented 2 years ago

Thanks for your contribution 🙇🏻 Interesting 👀

Thanks for pointing that out. At the moment the module supports down to version Go 1.15. I imagine this PR would probably break older versions. This means we would need to publish a new major version of the library to support 1.19, and would probably need to add a bunch of tests also.

I'll create a dedicated milestone, and prepare for doing just that. This PR will fall into this new version then 👍🏻

oleiade commented 2 months ago

I have bumped the Go version, and I believe this is now outdated.