search

oleksandrbalan / lazytable

Lazy layout to display columns and rows of data on the two directional plane.
Apache License 2.0
261 stars 12 forks source link

Implement the ability to add a pinned footer to the LazyTable. #19

Closed mattgraham1 closed 5 months ago

mattgraham1 commented 6 months ago

Closes #17

Description: Implemented the ability to add a pinned footer row to a LazyTable. Updated the configuration to allow consumers to set a footer flag indicating to pin a footer row. We also updated the MinaBox call within the LazyTable to pass the table height to the toMineBoxItem extension function and added an extra item to push the second to last row up when accounting for a pinned footer row. Within the toMineBoxItem extension function we accounted for adjusting the y coordinate and how lockVertically is set.

Evidence of changes:

https://github.com/oleksandrbalan/lazytable/assets/9346240/93433483-46c5-4fad-b53d-3779691dd1da

desktop_lazytable1 desktop_lazytable2 desktop_lazytable3
mattgraham1 commented 5 months ago

Just a few nitpicks 👀

Thx once more 👍

Also take a look on a "spotless" action result, you could also run it locally: ./gradlew spotlessCheck (or ./gradlew spotlessApply to auto-apply suggestions)

Ran the spotless check and applied the suggested changes in commit c72e4c3b4ada93373d8e93fff7759b9214f17e5c.

oleksandrbalan commented 5 months ago

Just a few nitpicks 👀 Thx once more 👍 Also take a look on a "spotless" action result, you could also run it locally: ./gradlew spotlessCheck (or ./gradlew spotlessApply to auto-apply suggestions)

Ran the spotless check and applied the suggested changes in commit c72e4c3.

Awesome, many thanks! :+1: