oleksandrbalan / modalsheet

Modal Sheet library for Jetpack Compose
Apache License 2.0
121 stars 6 forks source link

Crashing with latest compose BOM 2023.03.00 #22

Closed ColtonIdle closed 1 year ago

ColtonIdle commented 1 year ago
java.lang.NoSuchMethodError: No virtual method getProgress()Landroidx/compose/material/SwipeProgress; in class Landroidx/compose/material/ModalBottomSheetState; or its super classes (declaration of 'androidx.compose.material.ModalBottomSheetState' appears in /data/app/~~c68PNDi44D--xILc_StEgg==/com.rollertoaster.app-as==/base.apk)
at eu.wewox.modalsheet.ModalSheetKt.ModalSheet-BzaUkTc(ModalSheet.kt:133)
at eu.wewox.modalsheet.ModalSheetKt.ModalSheet-BzaUkTc(ModalSheet.kt:61)
at com.MyModalSheetKt.MyModalSheet
filwiesner commented 1 year ago

Thanks for the report, Colton!

@oleksandrbalan we've discussed this change before but I think we kinda slept on it and now the stable version of 1.4 is out :D The new version of sheet state has (at least in M3 but should be the same in M2) sheetState.requireOffset() function. Maybe it can be used for the same thing as progress before. But if I remember correctly the progress was used only for mitigating some bug/instability and maybe that's already fixed here 🤔

oleksandrbalan commented 1 year ago

Yea, I have been experimenting with it and yesterday I pushed an update to the separate branch and released 0.4.0-SNAPSHOT from it.

On Slack Colton said he will test it 🙏 and if everything works fine we could release a 0.4.0 with a newest compose version.

@wooodenleg I will soon create a PR with it 👌

EDIT: Ok, that's not the way how snapshot libs are released, so I have released 0.3.1 with that change 🙈

oleksandrbalan commented 1 year ago

The brand new 0.4.0 version is released with BOM 2023.03.00 🎉

Thx everyone for testing and review 🙇