oleksandrbalan / programguide

Lazy layout to display program guide data on the two directional plane.
Apache License 2.0
43 stars 7 forks source link

Android TV Focus? #18

Open techker opened 3 months ago

techker commented 3 months ago

How can we use this on tv?there is no Focus for navigation with Dpad?is there a way to add it without touching the libs?

oleksandrbalan commented 3 months ago

I would recommend to add an onFocusChanged modifier to your composables for program cell / channel / timeline, and use an appropriate ProgramGuideState::animateTo* method for each.

Check my answer here https://github.com/oleksandrbalan/programguide/issues/8#issuecomment-1810123264

sajidalidev commented 1 week ago

Hey @techker , have a look at my repo. Its still in early stages but it is developed for TV first and it can handle very large datasets https://github.com/sajidalidev/compose-epg-viewer/tree/develop . I appreciate your feedback to improve the library https://github.com/sajidalidev/compose-epg-viewer/tree/develop

techker commented 1 week ago

hey, thx for the reply i will take a look for sure..been on this for a while..have different version im testing out. last one seems better, but still issues in navigation due to lots of data.. https://github.com/techker/ComposeTV_EPG

sajidalidev commented 1 week ago

@techker I have had a quick look and it seems like you're not using lazy layouts(LazyColumn or LazyRow) or filtering the data to draw only visible data. You can check the Channels , Events composable in my repo. It should give you the idea.

techker commented 1 week ago

ya, the first tries i was, but having issues with horizontalScrollState vs vertical, then i noticed in my last example was able to do some workarounds with Surface.. not easy..lol thx for the help

On Fri, Oct 25, 2024 at 10:30 AM Sajid Ali @.***> wrote:

@techker https://github.com/techker I have had a quick look and it seems like you're not using lazy layouts(LazyColumn or LazyRow) or filtering the data to draw only visible data. You can check the Channels , Events composable in my repo. It should give you the idea.

— Reply to this email directly, view it on GitHub https://github.com/oleksandrbalan/programguide/issues/18#issuecomment-2437977557, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOFGYRLBA4RYEP6DHJUZWTZ5JIYNAVCNFSM6AAAAABKVIXPNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXHE3TONJVG4 . You are receiving this because you were mentioned.Message ID: @.***>

sajidalidev commented 1 week ago

No issues :)

techker commented 1 week ago

Ya...i hate to admit it but i hate you LOL, i have been on this for a while on and off since my job is taking lots of my time, never got it to were your code is at.. i imported the jctvguide lib in my code and works very good.. now il study it to see where i went wrong and adapt it tweek it... i see i was close..but you nailed it. Thx again for your help. it will never be a release, but for sure i will credit your work on my page.

sajidalidev commented 1 week ago

Haha, no worries. Happy to help. Let me know if you have any further questions.