olentangyfrc / DeepSpace-2019

FIRST Robotics Team OZONE (4611)'s 2019 DeepSpace code
12 stars 2 forks source link

Review custom scouting form functionality #398

Open Eiim opened 5 years ago

Eiim commented 5 years ago

I've linked to an example form. Consider this a "tech demo." It's designed for mobile, but usable on desktop as well. Features:

Feedback would be appreciated, especially if you can test it on your mobile devices to check if anything is off. How it looks in Chrome is the "canonical" version, any differences in Safari, Firefox, or Opera mobile would be great to know about. I haven't been able to test all of these, especially because Chrome is much nicer to test developments in.

Please note that this is not intended to be a complete form. Of course, main period, end game, and other inputs will be added or changed, per #293.

Again, any feedback on the look and feel or suggestions for custom inputs would be appreciated. The website will be updated semi-regularly with additional functionality, so check back occasionally. I've assigned a few people who have expressed interest or who I think would be valuable in this process. Of course, all are welcome to take a look and give feedback

(https://script.google.com/a/macros/we3chapmans.com/s/AKfycbxCdeN3t-Ni8DkfZ5ga8BeWKD9xSl37PLOCUJeGOcrRrmUrAQDd/exec)

JacobBraniger commented 5 years ago

It's really good so far. My one complaint is how long the return time is for the scouting information. If there is any way at all to speed that up, please do or add a loading icon or block the button until the report is received or something. I garuntee there will be someone who manages to click it so many times they end up missing an entire match because they only saw those reports for like 5 minutes straight.

Eiim commented 5 years ago

Can you elaborate which buttons took long to respond?

Most likely, you caught the server when it was down and it had to restart and reconnect, which takes about 10-20 seconds. This should happen only once or twice per day at events, as scouts will be keeping the server up. Process times for functions are all around 1 second or less.

Adding a loading image for the form submission is doable, although the team number and match requests, which are more prone to long load times because they are generally executed earlier.

On Fri, Feb 22, 2019, 18:59 JacobBraniger <notifications@github.com wrote:

It's really good so far. My one complaint is how long the return time is for the scouting information. If there is any way at all to speed that up, please do or add a loading icon or block the button until the report is received or something. I garuntee there will be someone who manages to click it so many times they end up missing an entire match because they only saw those reports for like 5 minutes straight.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/olentangyfrc/DeepSpace-2019/issues/398#issuecomment-466589365, or mute the thread https://github.com/notifications/unsubscribe-auth/AXfHclEWZPew8BPFAw3hub4oZPf6EdL7ks5vQIRKgaJpZM4a34-V .

On Fri, Feb 22, 2019, 18:59 JacobBraniger <notifications@github.com wrote:

It's really good so far. My one complaint is how long the return time is for the scouting information. If there is any way at all to speed that up, please do or add a loading icon or block the button until the report is received or something. I garuntee there will be someone who manages to click it so many times they end up missing an entire match because they only saw those reports for like 5 minutes straight.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/olentangyfrc/DeepSpace-2019/issues/398#issuecomment-466589365, or mute the thread https://github.com/notifications/unsubscribe-auth/AXfHclEWZPew8BPFAw3hub4oZPf6EdL7ks5vQIRKgaJpZM4a34-V .

Eiim commented 5 years ago

New version, new buttons, new bugfixes! Specifically, support buttons were added (we'll discuss Sat.) and Yellow/Red card indicators were fixed to reset properly upon a new submission. If you find any issues, let me know