search

oleobal / rockstar-interpreter

A Python interpreter for the Rockstar programming language
GNU General Public License v3.0
0 stars 0 forks source link

Merge Bool into Master #4

Closed zebralt closed 6 years ago

zebralt commented 6 years ago

As the title says. Let's see what exactly a pull request does. But seriously, I implemented the conditional operators. They work, but they suffer from the same reducing problem as arithmetic expressions. This will need to be addressed at some point. But for now, and since the spec does not detail complex expressions, we can do with simple ones.

oleobal commented 6 years ago

Good job ! Feel free to delete the branch and work on master.

However test-blocks.rock and test-blocks-2.rock don't seem to work anymore.

I'm happy runtests.py is so useful.

zebralt commented 6 years ago

Since we're on the topic of tests, runtests.py is not a cross-platform implementation. Maybe you could put the expected output in one file for each input file (in a test directory) and write a more platform-agnostic test program. And to be able to add tests easily, you could put the list of tuples (input, output) in a separate file too, so the test implementation doesn't have to be modified every time a new feature is put into the project and a new test is required to test it.

oleobal commented 6 years ago

I don't have a Unix on hand, don't blame me. What's not working ?

I'll put the expected output out of the file though. Good idea, give me a few hours.