olets / zsh-abbr

The zsh manager for auto-expanding abbreviations, inspired by fish. ~13,000 unique cloners as of May '24, 580+ Homebrew installs 6/23-6/24
https://zsh-abbr.olets.dev
Other
510 stars 18 forks source link

Support expansion when in Vi mode #29

Closed AtifChy closed 3 years ago

olets commented 3 years ago

Tell me more about the behavior you'd expect? (Expansion of course, but should it still be space-triggered?) If we can figure out a good default I'd be happy to include it.

I don't use Vi(m) and don't have an intuition for how it should work. Adding this to your zshrc might good place to start if you want to experiment.

[edit in case anyone happens on this comment in the future: this was incorrect, the following declarations are not the fix]

bindkey -M vicmd " " _abbr_widget_expand_and_space
bindkey -M vicmd "^M" _abbr_widget_expand_and_accept
bindkey -M vicmd "^ " magic-space
AtifChy commented 3 years ago

It should behave normally in insert mode.

olets commented 3 years ago

bindkey -v is wiping out the zsh-abbr key bindings. zsh-abbr does not work if you initialize it before setting vi mode, and does work if you initialize it after setting vi mode.

The quickest way to test whether or not that's the problem for you is to run _abbr_bind_widgets.

If that enables abbreviation expansion in the current terminal, the final fix will depend on how you have things set up. If your .zshrc has bindkey -v or some vi mode plugin, move that above the point where you add zsh-abbr.

olets commented 3 years ago

That note 👆 is now in the readme. Closing due to lack of activity