Closed Icy-Thought closed 1 year ago
Thanks for the report!
I was able to replicate this.
Possible it's a zsh-autosuggestions bug, possible I'm misunderstanding how to use the tools zsh-autosuggestions provides for clearing suggestions. I've opened a zsh-autosuggestions issue. Labelling this issue "needs more info" not because I need info from you but because I need info from zsh-autosuggestions.
Good to know! Also, thank you for putting in the time and effort to solve this issue!
Figured it out. Should be fixed in https://github.com/olets/zsh-abbr/releases/tag/v4.8.3 and https://github.com/olets/zsh-abbr/releases/tag/v5.0.0.beta-3. Let me know if it continues to give you trouble!
Will do! And thanks again for fixing it! :)
Just installed + tested the latest release and I can confirm that this issue has indeed been resolved! :tada:
Closing this issue since no further investigation/fixes are required.
Belatedly acknowledging more contributors in https://github.com/olets/zsh-abbr#community and https://zsh-abbr.olets.dev/community/
Would you like to be added @Icy-Thought? If so, I'll have the all-contributors bot open a pull request. Then I'll tag you in it to review for correct info
I guess I could be added to the site with the packaging tag? :shrug:
Was planning on migrating zsh-abbr
to Guix after migrating anyways since I noticed it was missing from the packages list.
Ok how about this: if that happens we revisit. Thanks!
Sure thing! I already maintain the nixpkg btw! 😉
Oh nice! I've added that to the docs https://zsh-abbr.olets.dev/installation.html#linux-package-repositories
Want to be acknowledged in the Community list for that?
Hehe. I should've mentioned it earlier! xD If you feel I should be there, add me. :blush:
@all-contributors please add @Icy-Thought for platform.
@Icy-Thought review the PR the bot posts below 👇 to see if the info it pulls is right
@olets
I've put up a pull request to add @Icy-Thought! :tada:
I do apologize if zsh-abbr is not at fault here, I am still a ZSH newbie who recently migrated from Fish..
What I am here to report today is that when
bindkey -M main "^M" abbr-expand-and-accept
is used, the suggestions provided by zsh-autosuggestions would still be printed after the entered command even though it was never accepted.And after some experimentation + searching I stumbled upon
bindkey -M main "^M" accept-line
which happens to solve the issue but at the cost of having no abbr on Enter.Before Enter:
After Enter:
I obviously do not know what the appropriate solution to this issue is and therefore I am here to request help from someone who is more knowledgeable than myself!