Authentication - Githubissues

oleville / oleville-voting-client

Web Client for SGA elections and referendums

1 stars 0 forks source link

Authentication #4

Closed elijahverdoorn closed 6 years ago

elijahverdoorn commented 7 years ago

Add login with google button, to use google's sign-in.

Developed in parallel with https://github.com/oleville/oleville-voting/pull/22, which adds the server-side of this work.

elijahverdoorn commented 7 years ago

Alright - this PR is getting stale and we need to make a decision. As I see it, there are 2 options here:

use the component seen here for google sign-in, accepting that we can't fully test the area that it is used.
write a new component for google sign-in (I can't find another that does what we want)

Thoughts, @erichkauffman, @rye?

erichkauffman commented 7 years ago

I think that if it does what we want it to do, we should forgo testing. With that, I think we need to keep in mind that if the area can't be tested then we should be cautious when adding new items to the area, especially items that really need testing.

rye commented 7 years ago

I would tend towards the first option, accepting the testing problems. We should poke at that some more and see if we can fix the errors in our testing situation.

elijahverdoorn commented 6 years ago

Alright - failing test removed. We're officially running without tests, but we're closer to a working flow. Can I get an approval, @erichkauffman or @rye?