search

olexale / arkit_flutter_plugin

ARKit Flutter Plugin
MIT License
790 stars 223 forks source link

Drawing feature added. #215

Closed Jaemin-VIRNECT closed 8 months ago

Jaemin-VIRNECT commented 8 months ago

Drawing feature added. (using SceneKit-SCNLine)

Example page : drawing_page.dart

olexale commented 8 months ago

Thanks for the PR! Unfortunately, I don't think it's a good idea to make it a part of the plugin. The plugin is supposed to be a wrapper for ARKit and this functionality is not included in the vanilla ARKit framework. I expect the absolute majority of the plugin users don't need this functionality, but it may cause maintenance issues due to one additional dependency.

However, I see another way to achieve the same functionality. What if you create a separate plugin, which may depend on this plugin + SCNLine native framework? In that plugin, you may define ARKitLineNode and write an extension function to the ARKitController to make it look like this functionality is included in the original package.

Jaemin-VIRNECT commented 8 months ago

Thank you for thinking about it. I appreciate the advice and will take it into consideration!