search

olexale / arkit_flutter_plugin

ARKit Flutter Plugin
MIT License
797 stars 225 forks source link

add maximumNumberOfTrackedImages #87

Closed mochetti closed 4 years ago

mochetti commented 4 years ago

Setting maximumNumberOfTrackedImages inside the ARKitSceneView constructor enables image tracking using worldTracking configuration.

olexale commented 4 years ago

Hi! Thank you so much your contribution!

May I propose a few changes?

  1. The documentation line "When set enables image tracking using worldTracking configuration" is not quite accurate. May I ask you to change it to

Maximum number of images to track simultaneously. Setting the maximum number of tracked images will limit the number of images that can be tracked in a given frame. If more than the maximum is visible, only the images already being tracked will continue to track until tracking is lost or another image is removed.

?

  1. The imageTrackingConfiguration has the same property. Could you please add it for the consistency as well?

  2. Could you please implicitly initialize the proposed variable with 0, so that the plugin users will know the default value?

Thanks one more time!

Kind Regards, Oleksandr

mochetti commented 4 years ago

Hey!

Added what you proposed.

Thanks again for the amazing work!

Regards, Mochetti

olexale commented 4 years ago

Great! Thank you! 👍🏻