olexale / bdd_widget_test

A BDD-style widget testing library
MIT License
101 stars 30 forks source link

Feature: Add custom tester type, name and scenario parameters #45

Closed mkhtradm01 closed 1 year ago

mkhtradm01 commented 1 year ago

Feature Request:

Based on the issue #44, some setup steps like the background (bddSetup) don't use the testMethodName provided by users via either tag in the .feature files or build.yaml file. So this PR resolves that and other scenarios:

It's cool and nice to have for more feasibility 😉 🍷

mkhtradm01 commented 1 year ago

Hi @olexale, can you review this please? thanks.

olexale commented 1 year ago

Hey @mkhtradm01,

Thanks for this PR, it took quite a while for me to do the review. I was hesitating about it as most of the things that this PR focused on are doable with the current implementation. At the same time, Patrol fans would love these changes. Unfortunately, the proposed changes dropped test coverage. Would you please bring it back to 100% so that I could merge it? Thanks in advance.

Kind regards, Oleksandr

mkhtradm01 commented 1 year ago

@olexale sure, I will take care of it, thanks for the review and acknowledgment 🥂

olexale commented 1 year ago

@mkhtradm01, thank you one more time for this PR. I'll play around with this functionality during the weekend and if everything is fine will publish a new version.