Closed mkhtradm01 closed 1 year ago
Hi @olexale, can you review this please? thanks.
Hey @mkhtradm01,
Thanks for this PR, it took quite a while for me to do the review. I was hesitating about it as most of the things that this PR focused on are doable with the current implementation. At the same time, Patrol fans would love these changes. Unfortunately, the proposed changes dropped test coverage. Would you please bring it back to 100% so that I could merge it? Thanks in advance.
Kind regards, Oleksandr
@olexale sure, I will take care of it, thanks for the review and acknowledgment 🥂
@mkhtradm01, thank you one more time for this PR. I'll play around with this functionality during the weekend and if everything is fine will publish a new version.
Feature Request:
Based on the issue #44, some setup steps like the background (
bddSetup
) don't use thetestMethodName
provided by users via either tag in the.feature
files orbuild.yaml
file. So this PR resolves that and other scenarios:Sometimes users may not wish to use
integration_test
orflutter_test
directly for their tests, they may choose to use other packages like Patrol or convenient_test and take advantage of this feature to pass their custom tester type, name or even the scenario parameters.Also this PR addresses this patrol limitation to use BDD
It's cool and nice to have for more feasibility 😉 🍷