search

olexandr-konovalov / LocalNRconstruction

Construction of local near-rings
0 stars 0 forks source link

Reduce the number of Union calls for order 625 #17

Open olexandr-konovalov opened 4 years ago

olexandr-konovalov commented 4 years ago

I am experimenting with Test625 examples, at the moment checking runtimes and compare outputs. Don't merge - this is work in progress.

olexandr-konovalov commented 4 years ago

P.S. for timings, It's not possible to run a smaller example:

gap> Read("End625_comb_new.g");time;

Comb 625
Error, List Element: <list>[625] must have an assigned value in
  for i in [ 1 .. li[j] ] do
    Bi := [ Binomial( t1, Com[j][i][1] ), Binomial( t2, Com[j][i][2] ), Binomial( t3, Com[j][i][3] ), Binomial( t4, Com[j][i][4] ), Binomial( t5, Com[j][i][5] ), Binomial( t6, Com[j][i][6] ) ];
    for i3 in [ 1 .. 6 ] do
        if Bi[i3] = 0 then
            Bi[i3] := 1;
        fi;
    od;
    Add( Ncom, Product( Bi ) );
od; at End625_comb_new.g:10 called from
<function "unknown">( <arguments> )
 called from read-eval loop at End625_comb_new.g:10
type 'quit;' to quit to outer loop
brk>

This is one more example demonstrating why we need organise the code into functions and establish more individual tests for each step of the algorithm.

olexandr-konovalov commented 4 years ago

Checked that this works correctly:

diff Endom625_11-500_17.txt out/Endom625_11-500_17.txt

does not report any diffs. Going to merge this.