olgabot / nf-kmer-similarity

MIT License
1 stars 0 forks source link

bam file compatibilty #31

Closed pranathivemuri closed 5 years ago

pranathivemuri commented 5 years ago

Many thanks to contributing to nf-core/kmer-similarity!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

Learn more about contributing: https://github.com/nf-core/kmer-similarity/tree/master/.github/CONTRIBUTING.md

pranathivemuri commented 5 years ago

changed the base branch to dev after reading the guidelines, but dev branch has some commits that are not in master, and viceversa too. But I wanted to make sure tests pass, and without pointing to dev tests are not passing because of this - '[ $TRAVIS_PULL_REQUEST = "false" ] || [ $TRAVIS_BRANCH != "master" ] || ([ $TRAVIS_PULL_REQUEST_SLUG = $TRAVIS_REPO_SLUG ] && [ $TRAVIS_PULL_REQUEST_BRANCH = "dev" ])' in .travis.yml

@olgabot let me know if I can remove it and base the PR off to master

olgabot commented 5 years ago

Similar to https://github.com/czbiohub/nf-kmer-similarity/pull/30, I just realized this was a PR to czbiohub/nf-kmer-similarity which I'm trying to deprecate. Can you close and reopen to https://github.com/nf-core/kmermaid ?

pranathivemuri commented 5 years ago

closing in favor of https://github.com/nf-core/kmermaid/pull/10