Closed pranathivemuri closed 5 years ago
changed the base branch to dev after reading the guidelines, but dev branch has some commits that are not in master, and viceversa too. But I wanted to make sure tests pass, and without pointing to dev tests are not passing because of this - '[ $TRAVIS_PULL_REQUEST = "false" ] || [ $TRAVIS_BRANCH != "master" ] || ([ $TRAVIS_PULL_REQUEST_SLUG = $TRAVIS_REPO_SLUG ] && [ $TRAVIS_PULL_REQUEST_BRANCH = "dev" ])'
in .travis.yml
@olgabot let me know if I can remove it and base the PR off to master
Similar to https://github.com/czbiohub/nf-kmer-similarity/pull/30, I just realized this was a PR to czbiohub/nf-kmer-similarity which I'm trying to deprecate. Can you close and reopen to https://github.com/nf-core/kmermaid ?
closing in favor of https://github.com/nf-core/kmermaid/pull/10
Many thanks to contributing to nf-core/kmer-similarity!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/kmer-similarity/tree/master/.github/CONTRIBUTING.md