Fix issue #48 : X and Y vectors can now be passed as pcolormesh argument

olgabot / prettyplotlib

Painlessly create beautiful matplotlib plots.

olgabot.github.io/prettyplotlib

MIT License

1.69k stars 148 forks source link

Fix issue #48 : X and Y vectors can now be passed as pcolormesh argument #55

Closed Mrngilles closed 10 years ago

Mrngilles commented 10 years ago

I patched the _pcolormesh file so that it your custom function can receive an X and Y axis (as in the original function). I also made it so that ticks with label get centered on the columns even if X/Y vectors are passed.

olgabot commented 10 years ago

Excellent! I haven't used this implementation of pcolormesh before so I was struggling to come up with a fix. Does this also work with ppl.pcolormesh(X, Y, C)?

Also, can you edit test_pcolormesh.py to include this case?

The build not passing is my fault, not yours - I'm still fixing it.

Mrngilles commented 10 years ago

Hi. Actually, getting the ppl.colormesh(X, Y, C) to work was my goal, so yes it works. I'll look into adding the case to test_pcolormesh.py

Also, just added a new fix for issue 53

About the compilation error, I don't really know what it is, it's my first contrib to a project...