kirasoderstrom
commented
4 years ago - In the staging branch patch is not used to create the crosslines or inlines but it is in the master branch. When using this script the index generated in the txt files seem to be past our data dimension boundaries. We want to use patch to create the crosslines and inlines
- The first patch highlighted is being used, but the second is not actually being used in the script as seen above. We should rename the second patch to patch_size to avoid confusion.
- I created splits for two different volumes and compared them. If you have dimensions for example (400, 500, 350) with a stride of 50 and patch of 100. I would expect the master branch for crosslines to go from horz_locations = range(0, 400-100, 50) so it would go from 0 to 300 at 50 stride intervals so we would see a print out up to 250 there but I would like to see it go out to 300 since we have data until 400. Although if we add 300+1 this would fix this. So I am recommending to consider including a plus one at that point incase the dimensions are exactly on a mark like this.
