Closed WeiguangTWK closed 9 months ago
Okay and I will do some changes according to your comments :)
Change submitted, please see if there's another problem
Thank you for the update. Just one more thing: translatable="false" for "app_name" is missing
@olgamiller OK, see if there's another thing to do :)
Thank you.
Unfortunately, I've noticed a few issues (that existed before the changes, but are now “visible” with the changes):
Would you like to fix these issues as well, all of them or a few? Otherwise, I'll merge this PR as it is now and fix the issues afterwards. Please let me know what you would prefer.
Additionally, I could not test the Font selection with System Language 简体中文. My emulator gets the "Default" item only, in the Font selection list. Would it be possible for you to check if it works as expected?
Thank you.
Unfortunately, I've noticed a few issues (that existed before the changes, but are now “visible” with the changes):
* The "size" string will be used for both, Font and Outline (and therefore "字体大小" will also be used for Outline Size) * The "color" string will be used instead of "outline_color" for the Outline Color * The following values are not in the strings.xml (and therefore will not be translated): * EditTextActivity: * {"Small", "Normal", "Large", "Huge"} * {"Thin", "Normal", "Thick"} * FontFamilySet: "Default"
Would you like to fix these issues as well, all of them or a few? Otherwise, I'll merge this PR as it is now and fix the issues afterwards. Please let me know what you would prefer.
Additionally, I could not test the Font selection with System Language 简体中文. My emulator gets the "Default" item only, in the Font selection list. Would it be possible for you to check if it works as expected?
Oh I got what happend: string "size" and "colour" have been used twice and I failed to notice it😂, I will now update the translation and test it, screenshot and new commit will be done soon
@olgamiller My IDE notices me that 10 warnings generated about activity_edit_text.xml, maybe some fixes are needed but at least now that two strings work on my phone
Check if there's any issues and I will try my best to assist
Yeah, this project is old, Android has changed a lot, therefore the warnings everywhere. Your changes are merged. Thanks for the fixes, and for the translations.
One question: Would the following translation make sense?
I've added missing strings to the string resources (see the latest updates). May I ask you to check whether the translation makes sense:
...
<string name="progressbar_message_sending">发送…</string>
<string name="progressbar_message_saving_to_file">%1$s 保存…</string>
...
<string name="font_default">默认</string>
...
<string name="font_size_small">小的</string>
<string name="font_size_normal">普通的</string>
<string name="font_size_large">大的</string>
<string name="font_size_huge">巨大的</string>
...
<string name="outline_size_thin">薄的</string>
<string name="outline_size_normal">普通的</string>
<string name="outline_size_thick">厚的</string>
(Please feel free to update/fix via another PR if necessary. Thanks.)
Yeah, this project is old, Android has changed a lot, therefore the warnings everywhere. Your changes are merged. Thanks for the fixes, and for the translations.
One question: Would the following translation make sense?
* "Small" -> “小的” * "Normal" -> “普通的” * "Large" -> “大的” * "Huge" -> “巨大的” * "Thin" -> “薄的” * "Normal" -> “普通的” * "Thick" -> “厚的” * "Default" -> “默认”
Generally speaking, that translation makes sense. But in many cases it depends on which kind of objects you're describing. For example, about the description of text or font, if you translate "huge" into "巨大的"—— although it might still make sense, but some how makes people feel strange to see expression like that and we call it "translation tone(翻译腔)" so in this example I prefer to translate "huge" into "特大号" like "XXL" size of clothes
@WeiguangTWK: Could you please provide an improved translation of the following strings (so the Chinese-Simplified translation would be really complete):
<string name="progressbar_message_sending">发送…</string>
<string name="progressbar_message_saving_to_file">%1$s 保存…</string>
...
<string name="font_default">默认</string>
...
<string name="font_size_small">小的</string>
<string name="font_size_normal">普通的</string>
<string name="font_size_large">大的</string>
<string name="font_size_huge">巨大的</string>
...
<string name="outline_size_thin">薄的</string>
<string name="outline_size_normal">普通的</string>
<string name="outline_size_thick">厚的</string>
@olgamiller Ok, here we go (Since some problem occured I deleted and reedit my reply, never mind)
`
<string name="progressbar_message_saving_to_file">%1$s 另存为文件</string>
...
<string name="font_default">默认字体</string>
...
<string name="font_size_small">小</string>
<string name="font_size_normal">常规</string>
<string name="font_size_large">大</string>
<string name="font_size_huge">很大</string>
...
<string name="outline_size_thin">细</string>
<string name="outline_size_normal">常规</string>
<string name="outline_size_thick">粗</string>
`
@WeiguangTWK: Thank you, I've implemented your suggestions.
DE BG7QWH and thank you for your awsome SSTV app