search

oli-obk / pandoc-ast

35 stars 11 forks source link

Update Pandoc version to 1.23 #14

Closed filiparag closed 1 year ago

filiparag commented 1 year ago

I'm not sure whether abolishing Pandoc version check upper bound would be beneficial in the long term 🤔

Right now, every time there is a new Pandoc release this library has to be manually updated, regardless of there being breaking changes or not. Maybe a better aproach would be to to panic only if filter's JSON can't be deserialized properly.

oli-obk commented 1 year ago

Hmm... usually such a bump requires us to update the json, but I guess it is annoying if it would still just keep working for the set of markdown you're using.

Yea I guess remove the upper limit.

filiparag commented 1 year ago

Besides removing the upper limit, I revamped version parsing so it fails earlier, before JSON gets deserialized to data. I hope you find it acceptable.