search

oli-obk / priroda

A graphical debugger for Rust MIR
Apache License 2.0
183 stars 13 forks source link

Add support for concurrent Miri #23

Closed vakaras closed 4 years ago

vakaras commented 4 years ago

This PR includes two changes:

  1. Update Priroda to work with the newest version of Miri.
  2. Change the step function to work with the updated interface of concurrent Miri.

This PR depends on https://github.com/rust-lang/miri/pull/1284

bjorn3 commented 4 years ago

@oli-obk It seems that the Travis CI integration broke.

oli-obk commented 4 years ago

works on master... cycling the PR

bjorn3 commented 4 years ago

This will need to change rust-toolchain once the rustc PR is merged.

bjorn3 commented 4 years ago

@vakaras https://github.com/rust-lang/miri/pull/1284 got merged. Can you update this PR?

bjorn3 commented 4 years ago

Friendly ping @vakaras.

vakaras commented 4 years ago

Sorry, for taking so long to update this. I am a bit swamped with other things right now.

vakaras commented 4 years ago

The rustup changes LGTM. For the thread support it would be nice to have a way to show the stack for every thread and if a thread is blocking, what it is blocking on.

I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that.

oli-obk commented 4 years ago

I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that.

that's totally fine in my book. We can add additional logic for showing the stack of other threads than the current one later. Let's just get the general logic working

bjorn3 commented 4 years ago

I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that.

that's totally fine in my book. We can add additional logic for showing the stack of other threads than the current one later. Let's just get the general logic working

Opened #25

oli-obk commented 4 years ago

Thanks so much for doing this and bearing with us through the changes!

vakaras commented 4 years ago

No problem and sorry that it took so long for me to come back to this.