search

oli-obk / ui_test

A test framework for testing rustc diagnostics output
27 stars 25 forks source link

"Building dependencies" looks like a revision #279

Open RalfJung opened 2 months ago

RalfJung commented 2 months ago

Here's some example output from ui_test:

tests/pass-dep/libc/ccrandomgeneratebytes_apple.rs ... ignored (in-test comment)                                                                                                                                   
tests/pass-dep/getrandom.rs 
  no_isolation ... ok
  isolation ... ok
tests/pass-dep/libc/libc-random.rs 
  no_isolation ... ok
  isolation ... ok
  Building dependencies ... ok

The last line is a bit confusing -- "Building dependencies" is a 'global' job, but the way it is intended makes it look like a revision of tests/pass-dep/libc/libc-random.rs. IMO it would be better not indented.

oli-obk commented 2 months ago

Yea... in the textual dump this makes no sense. It's better in the interactive version where it shows up on all tests, indicating that they are blocked on it

RalfJung commented 2 months ago

That's not what happens for me, it only shows up for a single test -- somewhat randomly in the middle of all the other tests:

image

oli-obk commented 2 months ago

Ah hmm... then that was an intermediate state that was too annoying or sth. I'll investigate