oli-obk / ui_test

A test framework for testing rustc diagnostics output

27 stars 25 forks source link

Move revision-specific args to a custom flag #291

Closed DaniPopes closed 4 weeks ago

DaniPopes commented 4 weeks ago

Closes https://github.com/oli-obk/ui_test/issues/290 by implementing the second suggestion in https://github.com/oli-obk/ui_test/issues/290#issuecomment-2447877332.

TODO (check if already done)

[x] Add tests
[x] Add CHANGELOG.md entry

Should already be tested by existing revisions tests.

DaniPopes commented 4 weeks ago

~~Not sure if I need to bless tests because doing so makes them pass, but they also contain "DO NOT BLESS. These are meant to fail". They also fail on main for me.~~

This is because 1.82 has different output. I've opened https://github.com/oli-obk/ui_test/pull/292 to address this separately.

oli-obk commented 4 weeks ago

hmm rerunning CI apparently doesn't rebase. Oh well, main branch CI will catch any issues (I don't forsee any)