search

oli107 / material-range-bar

Android widget for selecting a range of values.
Apache License 2.0
1.68k stars 370 forks source link

allow pinColor transparency #150

Closed amoslital closed 5 years ago

lital-nanit commented 5 years ago

I added a change that supports alpha value for the pin color in general. What I actually needed is to only show the pin text without the bubble itself and I thought about several ways to support it:

  1. Support any alpha (what is in the P.R).
  2. Disable filter only when given android.R.color.transparent.
  3. Add a showOnlyPinLabel styleable value.

Hope you'll accept any of these.

krazykira commented 5 years ago

@lital-nanit i like the 3rd approach better. Once you create a PR i will be happy to review it. @amoslital Maybe you want to do it like @lital-nanit explained (3rd point)

amoslital commented 5 years ago

We're actually the same person I just mixed my accounts. Fixed the P.R. Thanks @krazykira .

krazykira commented 5 years ago

@amoslital i checked PR #141 and it seems this functionality can be achieved without changing the code by assigning transparency to app:mrb_pinColor so i will be reverting the commit and merging the other PR. Thankyou for your help anyways

        app:mrb_pinColor="@android:color/transparent"/>
lital-nanit commented 5 years ago

@krazykira Great. Thanks!