Add touch started and touch ended callbacks to listener

oli107 / material-range-bar

Android widget for selecting a range of values.

Apache License 2.0

1.67k stars 370 forks source link

Add touch started and touch ended callbacks to listener #162

Closed MrXlebNick closed 5 years ago

MrXlebNick commented 5 years ago

There are use cases in which listener should not be called as the pin moves (let's assume a user has a heavy call on position changed). In this case, two new callbacks are convenient (onTouchStarted and onTouchEnded): when the pin moves, user can store its new value, and when touch ended, a heavy call can be executed with these positions

kwikadi commented 5 years ago

Hey maintainers, when do you guys reckon this pull will be merged/released ? This project is really the only one I can find which does the material guidelines justice, and onTouchStarted and onTouchEnded callbacks are exactly what I need for a project I'm working on these days. (Which isn't to say that you are beholden to random people on the internet for timelines, but there has been no activity on this pull for some time, so I just wanted to know when you reckon this will be merged)

krazykira commented 5 years ago

Looks Good. Thanks for your contribution. Will be merged and released in version 1.4.6

Rlshep commented 5 years ago

Can you add call to onTouchEnded to end of setRangePinsByValue?