search

olia-dev / kopano-webapp-fetchmail

The Plugin allows the user to configure one or more accounts to be polled via fetchmail inside of Kopano WebApp.
Other
7 stars 6 forks source link

Fix to store the full E-Mail Address in MySQL #8

Closed haggybear closed 6 years ago

haggybear commented 6 years ago

Fix to store the full E-Mail Address in MySQL to deliver the mails from fetchmail not just the prefix. If only the prefix is stored, fetchmal isn't able to deliver the fetched mail to the correct kopano account. #7

olia-dev commented 6 years ago

Sorry for the late answer, currently not much time to maintain this project.

Regarding the fix: was there a change in the kopano source code in a new version? Because for me the function: container.getUser().getEmailAddress( ) still returns the complete mail adress for the user.

haggybear commented 6 years ago

Thank you for the answer. I think it depends how kopano was set up. If the shortname option is chosen the method only returns the prefix. IMHO it's better to use getSMTPAddress.

fbartels commented 6 years ago

I had a small chat with our WebApp qa over this, the last change to this function was in 2016. That it returns the username is expected, since this is what is stored for the kopano adresstype. So changing it as suggested is the safe way to always get a full smtp address.

olia-dev commented 6 years ago

Okay, since in my installation the username is equivalent to the full mail address it always worked.

@fbartels thanks for asking the QA team. @haggybear thanks for the patch, I will merge it and release a new build (soonish)