oliexdev / openScale

Open-source weight and body metrics tracker, with support for Bluetooth scales
GNU General Public License v3.0
1.68k stars 292 forks source link

onebyone: visceral fat calculation is bogus #749

Open lbdroid opened 3 years ago

lbdroid commented 3 years ago

Describe the bug The calculation for visceral fat uses ONLY weight, height, and age inputs.

Much like BMI, it makes no distinction between a pound of fat and a pound of muscle. Someone who is morbidly obese and someone who is extremely fit and muscular may weigh the same, and therefore have the same visceral fat calculated, despite a vast difference in reality.

This should be changed to use a calculation involving measured fat, such as https://github.com/oliexdev/openScale/blob/master/android_app/app/src/main/java/com/health/openscale/core/bluetooth/lib/YunmaiLib.java#L118

oliexdev commented 3 years ago

Well the Yunmai calculation was reverse engineered from the Yunmai scale and they use (for whatever reason) the measured fat.