search

oliexdev / openScale

Open-source weight and body metrics tracker, with support for Bluetooth scales
GNU General Public License v3.0
1.71k stars 296 forks source link

Beurer BF720 wrong max user count? #890

Closed AlBundy33 closed 1 year ago

AlBundy33 commented 2 years ago

https://github.com/oliexdev/openScale/blob/1e3d15c3f1ddd0af87476c47f1a90afe71c7ead0/android_app/app/src/main/java/com/health/openscale/core/bluetooth/BluetoothBeurerBF105.java#L67

according to https://www.beurer.com/web/de/produkte/wellbeing/gewicht-und-diagnose/diagnosewaagen/bf-720.php value should be 8

oliexdev commented 1 year ago

you link refers to the BF 720 website. The source code is for BF105, so it should be this link https://www.beurer.com/web/de/produkte/wellbeing/gewicht-und-diagnose/diagnosewaagen/bf-105.php

and there we have 10 max user accounts.

AlBundy33 commented 1 year ago

?!? That's correct but you use the same class for BF720 and therefore I've created the issue.

https://github.com/oliexdev/openScale/blob/1e3d15c3f1ddd0af87476c47f1a90afe71c7ead0/android_app/app/src/main/java/com/health/openscale/core/bluetooth/BluetoothFactory.java#L122