clipboard paste not working in empty tables in chrome

olifolkerd / tabulator

Interactive Tables and Data Grids for JavaScript

http://tabulator.info

MIT License

6.6k stars 811 forks source link

clipboard paste not working in empty tables in chrome #1251

Closed AndreasEpp closed 5 years ago

AndreasEpp commented 6 years ago

Hello all,

The clipboard past functionality is not working properly in Chrome (at least for me). The problem occures in two scenarios:

Empty table: When the table is empty I can not focus it no matter where I click (column headers, background, etc) and therefore not paste in it.
Grouped rows: When the rows in the table are grouped, the only way to focus on it is to click on the group-header or a row.

All this is not a problem when the table is not empty and the rows are not grouped. Then it does not matter where I click on it, it will focus on the table and let me paste in it.

The element it seems to focus on when I can not trigger the paste action is the div element which renders the background (class="tabulator-tableHolder").

On Firefox, none of this is an issue.

Here is what I've used:

Tabulator v3.5.2
jQuery v3.3.1
Google Chrome Version 67.0.3396.99
Firefox 61.0

AndreasEpp commented 6 years ago

Also no problem in Microsoft Edge Microsoft Edge 42.17134.1.0 Microsoft EdgeHTML 17.17134

olifolkerd commented 6 years ago

Hey @Swagrid9000

Thanks for letting me know, i will look at getting a fix for this into tomorrows 4.0 re;ease.

Cheers

Oli :)

olifolkerd commented 5 years ago

Hey @Swagrid9000

Turns out Chrome dosn't like pasting into visibly empty div's,

I have pushed a patch for this to the 4.0 branch which will be released later today.

Cheers

Oli :)

AndreasEpp commented 5 years ago

@olifolkerd Amazing, thank you !

WhiteWind commented 4 years ago

Not working again in 4.7.2

olifolkerd commented 4 years ago

We are now on version 4.8

On Sat, 12 Sep 2020, 11:55 Mikhail Avdienko, notifications@github.com wrote:

Not working again in 4.7.2

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/olifolkerd/tabulator/issues/1251#issuecomment-691469088, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUGBTEU4IC5Y6PCJG77FULSFNHSNANCNFSM4FIUMSMQ .

WhiteWind commented 3 years ago

Not working in version 4.8.1

<div id="invoice-table" tabindex="0"></div>
<script>
table = new Tabulator('#invoice-table', {
                height: 205, 
                index: 'ID',
                data: rows,
                layout: "fitColumns", 
                virtualDom: false,
                selectable: false,
                clipboard: true,
                clipboardPasteAction: "replace",
                clipboardCopyConfig: {
                    columnHeaders: false,
                    columnGroups: false, 
                    rowGroups: false, 
                    columnCalcs: false,
                    dataTree: false, 
                    formatCells: false, 
                },
                columns: columns,
            });
</script>

olifolkerd commented 3 years ago

Hey @WhiteWind

I have pushed a fix for this to master and will include it in today's patch release.

Could i ask that in future if you discover a bug you create a new issue rather than comment on two year old issues, it makes it really hard to track if an issue is resolved if you comment on long closed issues.

Cheers

Oli :)

WhiteWind commented 3 years ago

Ok, understood