updateData function consumes all the available memory

[ch3sn3k]

Describe the bug I have a table with roughly 500 rows, where only 50 are visible. Few cells in the row are static, and few of the periodic changes are based on the data from the server. I am reading numeric (float) values and some strings. I am using updateData function to update selected rows based on the current data. This function is called every 2000ms. The problem is that after a while, the page consumes all available memory and the browser shuts down the tab.

Tabulator Info

• 5.4

Working Example https://jsfiddle.net/zag41ted/32/

To Reproduce Just run the example and watch the Task manager. You can adjust the setInterval delay to speed up the memory consumption.

Expected behavior Do not create new cell objects?

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser Opera
• Version 93.0.4585.21

Additional context Add any other context about the problem here.

[olifolkerd]

You need to use replaceData not updateData

[ch3sn3k]

@olifolkerd Thank you for the fast response. Still, I think this is some kind of issue. I am glad I can use your project, but the problem with your solution is a huge performance issue. In my case, I need to store the data for the table in a separate object. This is OK. But replaceData takes only the whole data, not just some rows. If I update the whole table with the replaceData function every 2000ms, it takes more than 1400ms to do the update. Can you advise me on how to solve my issue?

[ch3sn3k]

Just to provide some more info. I am updating only some values in the table, not the whole row. In my example above the values are either even or odd indexes.

[olifolkerd]

Hey @ch3sn3k thanks for the additional info.

Can I ask how your table is usable when using updateData at that rate. Calling that function resets scroll position which will have a very bad affect on usability for anyone using the table

[ch3sn3k]

Hello @olifolkerd, I do not understand your question, or I do not struggle with scroll issues. Even in the fiddle, you can see that if I scroll the table and call the updateData function periodically, the component behaves as I would expect. The scroll position remains, and data are just updated Thanks to your VirtualDom I am able to have all the rows loaded. The problem here is memory consumption. I am trying to overcome memory consumption with the following approach:

• Use replaceData function, but this doesn't help at all since the rendering time of the table is too long.

• Get a reference to a concrete cell using table.getRow().getCell() and use setValue() function to update the values. But the problem is that when the cell is rendered once and then the table is scrolled, it gives me an error that the cell element does not exist

• A try to do a combined approach when I call updateData whenever the data changes, and once in a while, I flush the table calling replaceData. But this also does not help.

Is there any other way how to alter the table data?

[jurafa]

I think that the issue is in the Row.js in the function getCell(column). If updateData is called for rows that are not yet visible the condition

if(!this.initialized){
    this.generateCells();
}

always causes new cells to be generated. The cells keep references to detached HTML items that therefore cannot be garbage-collected causing memory-leaks.

If the condition is adjusted to check if the cells were already generated, the leak seems to be gone:

if(!this.initialized && this.cells.length === 0) {
    this.generateCells();
}

[JohnL404]

@ch3sn3k We desperately need a fix to this. The solution provided in the PR by @jurafa does work, but we've had to pull down the Tabulator source and incorporate it into our project directly at this time.

[ch3sn3k]

@olifolkerd Do you think that the suggested solution from @jurafa is sufficient for this issue? As @JohnL404 requested I am not only one suffering with this issue. Can you consider the merge request?

[olifolkerd]

Hey, sorry for the delay in getting back to you on this one. Not ignoring things, just been dealing with a family emergency the last couple of weeks.

Normal service will resume soon, will look at getting a patch release out with these fixes in later this month.

Thanks for your patience

Oli