olifolkerd / tabulator

Interactive Tables and Data Grids for JavaScript
http://tabulator.info
MIT License
6.6k stars 811 forks source link

Vertical scrolling breaks after repeated addRow() #4123

Closed TI-AviBerko closed 1 year ago

TI-AviBerko commented 1 year ago

Describe the bug Vertical scrolling breaks after repeated addRow().

Tabulator Info v5.4.3

Working Example https://jsfiddle.net/aviberko/zLxwu18y/

To Reproduce A step by step guide to recreate the issue in your JS Fiddle or Codepen:

  1. Create a table with height to enable virtualdom
  2. Add lines with addRow() until the scroll bar appears
  3. Scroll up and down
  4. Observe that rows at the bottom of the table aren't being rendered

Expected behavior Rows should be rendered correctly. This jsfiddle example works correctly with v5.4.2

Screenshots image

Desktop (please complete the following information):

olifolkerd commented 1 year ago

Hey @TI-AviBerko

I have pushed a fix for this to the master branch and will include it in todays patch release.

Cheers

Oli :)

TI-AviBerko commented 1 year ago

@olifolkerd it works fine now, thank you.