search

olifolkerd / tabulator

Interactive Tables and Data Grids for JavaScript
http://tabulator.info
MIT License
6.71k stars 818 forks source link

Frozen Column render error with tabulator_bootstrap.css #589

Closed michaelongithub closed 7 years ago

michaelongithub commented 7 years ago

Hi Oli if one has

    <LINK href="tabulator/tabulator.min.css" rel="stylesheet">
    <LINK href="tabulator/tabulator_bootstrap.min.css" rel="stylesheet">

and frozen cols on left f.i. moving scrollbar overlays frozen cols with scrolled cols. Cause: .tabulator .tabulator-row { position: relative; box-sizing: border-box; min-height: 30px; background-color: transparent; border-bottom: 1px solid #ddd; } Temp fix for me: background-color: #fff;

But this is in general not good.

Problem known? Ideas how to fix ?

Cheers Michael TabulatorTests.zip

olifolkerd commented 7 years ago

Hey Michael,

you should only include one CSS file. not both.

Let me know if that helps

Cheers

Oli

michaelongithub commented 7 years ago

Hey Oli as far as I can test (in Example I sent), problem remains. And would have expected that from what I thought was the cause of the problem Cheers, Michael

michaelongithub commented 7 years ago

BTW, how can I set standard Bootstrap classes for stripes, condensed, border of table etc with Your Bootstrap theme. In Your example on Your site: Also no table border and Headers not visible, Checked up Bootstrap doku: table-striped, table-bordered, table-condensed. Same in Bootstrap 3 and 4. table-hover could be considered differently, since it could be thougt of as general attribute.
Not sure, if some of these should maybe considered as general, theme - independent table attributes. Cheers, Michael

olifolkerd commented 7 years ago

You should just be able to apply the bootstrap classes to your tabulator element and they should work. let me know if they dont

michaelongithub commented 7 years ago

Yes, works, thanks, very good solution. So the original problem remains. Cheers, Michael

michaelongithub commented 7 years ago

Closed by accident. I meant the frozen column problem with the bootstrap theme

michaelongithub commented 7 years ago

and again, sorry

olifolkerd commented 7 years ago

On further investigation this is because by default bootstrap sets the background colour of its tables to transparent, this is then pulled through to the rows, which then don't render correctly when frozen.

i will look at fixing this in this weekends release, but it may well end up with the default background colour being set to white

michaelongithub commented 7 years ago

Thanks a lot for having a look at it.

olifolkerd commented 7 years ago

Hey @michaelongithub

You will be happy to hear that in today's 3.3 release this bug has now been fixed.

Cheers

Oli :)