olifolkerd / tabulator

Interactive Tables and Data Grids for JavaScript
http://tabulator.info
MIT License
6.78k stars 820 forks source link

How to support RTL #729

Closed technoplusplus closed 4 years ago

technoplusplus commented 7 years ago

Is there any way to support RTL languages?

olifolkerd commented 7 years ago

Hey @technoplusplus ,

as long as you have set the direction to rtl in your CSS, Tabulator should be fine. are you having any particular issues with it?

Cheers

Oli

technoplusplus commented 7 years ago

I tried setting the direction to RTL but we found some many issues :

One of the major issues was the scroll width and the alignment of header with the body because as I found

1-You set margin_left to adjust the header with body while scrolling (to avoid scrollbar width) but since we are in RTL mode we found that the header is not well-adjusted with the body and there is a little shift between the headers and body

2-using groups, in RTL when we close all groups (collapse) the group headers stay in LTR mode which is not correct

3-The text doesn’t start from right to left in RTL Mode

4-the horizontal scroll doesn’t work properly when table is empty and you have a lot of columns such as (50 column) in RTL Mode

5-resizing columns is not working properly in RTL Mode

Once you set the direction to RTL you will find all of the above problems without any configuration

You just need to have like 40 or 50 columns

Group by columns (say 2 groups)

500 records

From: Oli Folkerd [mailto:notifications@github.com] Sent: Tuesday, November 21, 2017 11:07 PM To: olifolkerd/tabulator tabulator@noreply.github.com Cc: technoplusplus yazan.allahham@technoplusplus.com; Mention mention@noreply.github.com Subject: Re: [olifolkerd/tabulator] How to support RTL (#729)

Hey @technoplusplus https://github.com/technoplusplus ,

as long as you have set the direction to rtl in your CSS tabulator should be fine. are you having any particular issues with it?

Cheers

Oli

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/olifolkerd/tabulator/issues/729#issuecomment-346161003 , or mute the thread https://github.com/notifications/unsubscribe-auth/ATw1ju0PWut29irneSSgKgQzrh3tCW3Dks5s4ztjgaJpZM4QmYR3 . https://github.com/notifications/beacon/ATw1jv0Sb-EvwTnoGh4BuCCN3BKIOhAmks5s4ztjgaJpZM4QmYR3.gif

olifolkerd commented 6 years ago

Hey @technoplusplus

I have added it to the roadmap to improve RTL language support in an upcoming release.

Cheers

Oli

B-Esmaili commented 5 years ago

any update on this?

olifolkerd commented 5 years ago

Hey @B-Esmaili

It is in the roadmap for this to be included in the next release. which should be in a month or two. it will likely be a gradual introduction with an initial offering in 4.3 and refinement over subsequent versions.

Cheers

Oli :)

B-Esmaili commented 5 years ago

Isn't there any temporary workaround for this issue? i am really stuck with it.

olifolkerd commented 5 years ago

Aside from the suggestions above i dont have any further suggestions at this moment.

Sorry

olifolkerd commented 5 years ago

@B-Esmaili

Can i ask what are the key features you are looking for in RTL support? i don't use an RTL language myself so it would really be useful to get a list of things that you consider nessisary.

Cheers

Oli :)

B-Esmaili commented 5 years ago

1 - Aligning columns from right (which should be done just by setting direction:rtl). but once doing that only text direction changes to rtl still columns align from left and this in turn causes column resizing to not function properly and column headers do not align with the column body. 2 - Branch element should be flipped horizontally to point right to left.

coda-apps commented 4 years ago

Did this happen in the end? I don't seem to be able to find it in the documentation. Thanks

olifolkerd commented 4 years ago

Hey @coda-apps

The issue is still open, which means it is still on the roadmap.

Im going to have a look at adding this functionality in the next release.

Cheers

Oli :)

olifolkerd commented 4 years ago

Hey All,

You will be happy to hear that i have just pushed the functionality for RTL support onto the 4.8 branch which will be released at the end of the month,

Cheers

Oli :)

coda-apps commented 4 years ago

Amazing thanks!

mostafaf commented 4 years ago

@olifolkerd Thanks for adding rtl support.

When it will be released ?

I don't have much time to choose datagrid.

olifolkerd commented 4 years ago

@mostafaf two days time, this sunday

mansourelbash commented 5 months ago

tabulatorTable.scrollToColumn not wokring on RTL Pages ,?