search

oligot / rollup-plugin-nodent

Rollup plugin for ES2017 async/await keywords
27 stars 2 forks source link

Upgrade acorn-dynamic-import dependency #8

Open marvinhagemeister opened 6 years ago

marvinhagemeister commented 6 years ago

One of the dependencies of this library is acorn-dynamic-import which depends on an older version of acorn. This causes problems when used together with newer acorn plugins that depend on acorn v6.

rollup-plugin-nodent is used in microbundle where we were running into exactly this issue: https://github.com/developit/microbundle/issues/74

Upgrading acorn-dynamic-import locally fixes the issue.

I'm happy to make a PR myself but looking at the content of yarn.lock it seems like a custom npm registry mirror is used and I don't have access to it.

oligot commented 6 years ago

As discussed in https://github.com/MatAtBread/nodent/issues/114, nodent-compiler still relies on Acorn v5 so I think that upgrading acorn-dynamic-import is sadly not enough.

oligot commented 6 years ago

Thanks to your comment, I've removed the custom registry in yarn.lock.