search

olikraus / dogm128

Automatically exported from code.google.com/p/dogm128
Other
20 stars 6 forks source link

remove default support for DOGM128 #119

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

1. I have multiple customers who did not know that they must define DOGS102.
Since DOGM128 loaded by default, they got picture but very poor quality and 
complained.
I would recommend you to remove default selection and generate compiler error 
if no LCD explicitly defined

Original issue reported on code.google.com by olikr...@gmail.com on 30 Jan 2011 at 7:31

GoogleCodeExporter commented 9 years ago 
#if !defined DOGM128_HW && !defined DOGM132_HW && !defined DOGS102_HW && 
!defined DOGXL160_HW_BW && !defined DOGXL160_HW_GR
#define DOGM128_HW
#endif
to 

#if !defined DOGM128_HW && !defined DOGM132_HW && !defined DOGS102_HW && 
!defined DOGXL160_HW_BW && !defined DOGXL160_HW_GR
#error LCD model is not defined. Define your LCD in dogm128.h
#endif

Original comment by olikr...@gmail.com on 31 Jan 2011 at 5:10

GoogleCodeExporter commented 9 years ago

Original comment by olikr...@gmail.com on 21 Feb 2011 at 11:12